Add support for QQuaternion #1314
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 13038 13038
=========================================
Hits 13038 13038 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thank you @jnbooth ! Really appreciate it :-) |
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Hi @jnbooth, thank you for for the contribution. Again, please excuse the delayed review.
The QQuaternion looks good. QGenericMatrix still has some room for improvement.
Co-authored-by: Leon Matthes <[email protected]>
…entity Co-authored-by: Leon Matthes <[email protected]>
…aw_parts" This reverts commit 5a53669.
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Sorry, just noticed the #[repr(..)] discussion is still unresolved.
Head branch was pushed to by a user without write access
LeonMatthesKDAB
left a comment
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Thank you for the contribution @jnbooth 🥳
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merge queue failed due to some fluke when updating the code coverage. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hm, now the macOS runner doesn't like to start... |
|
@LeonMatthesKDAB I think it might be this:
|
|
Good catch @jnbooth , we'll have to update our macOS runners then. |
3 participants
Closes #1308.